Does not support Pry.editor proc

[felixbuenemann]

The code doesn't handle the code where Pry.editor is not a simple path but a proc, eg.:

Pry.editor = proc { |file,line|
  "mvim -f -c 'au VimLeave * !open -a iTerm' #{file} +#{line}"
}

The code should check if editor.is_a? Proc and then use editor.call(filename, 1).

I'll try to make a PR once I find some time.

(If anyone's curious, the above code focuses iTerm after closing MacVim started from Pry.)

[tpope]

Definitely interested. Out of curiosity, is there a reason you can't use a
string in this particular case?

On Wed, Mar 6, 2013 at 8:05 PM, Felix Buenemann notifications@github.comwrote:

The code doesn't handle the code where Pry.editor is not a simple path but
a proc, eg.:

Pry.editor = proc { |file,line|
"mvim -f -c 'au VimLeave * !open -a iTerm' #{file} +#{line}"}

The code should check if editor.is_a? Proc and then use editor.call(filename,
1).

I'll try to make a PR once I find some time.

(If anyone's curious, the above code focuses iTerm after closing MacVim
started from Pry.)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/4
.

[felixbuenemann]

It's required so pry knows how to supply the line number, see this url for details:

https://github.com/pry/pry/wiki/Editor-integration#wiki-Set_editor

[tpope]

But right here is a very liberal regex that should correctly figure it out, no?

[felixbuenemann]

Yes, you are right, that should be sufficient. I guess I looked at the documentation and not the source when I added that line to my .pryrc ;-)

[felixbuenemann]

Btw. why not hook directly into pry to invoke the editor? That way the code would not be duplicated. There's a public method Pry::Editor.invoke_editor(file, line, blocking).

[tpope]

I'm not sure that that existed back when I first wrote pry-editline. But yeah, it sounds like the way to go (so long as irb compatibility is maintained).

[felixbuenemann]

Ah, yes there's still people using that. I'll give it a shot.

[felixbuenemann]

Btw. big ❤️ for all the great vim plugins!