Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:Gpush pushes but doesn't exit cleanly with Neovim #867

Closed
jc00ke opened this issue Jan 17, 2017 · 3 comments
Closed

:Gpush pushes but doesn't exit cleanly with Neovim #867

jc00ke opened this issue Jan 17, 2017 · 3 comments

Comments

@jc00ke
Copy link

jc00ke commented Jan 17, 2017

As always, thanks for your tireless work!

I'm not sure if the regression is in Neovim or fugitive but this used to work without errors.

I'd :Gpush -u which runs Credo in a pre-push hook, then kicks the code up. When that completes I get the following error:

0_selection_001

I'm on Neovim 0.1.7ubuntu1+git201701151345+3058+23~ubuntu16.10.1 (maybe I should get off the unstable release?) and b754bc2 using Plug to manage my plugins.

@justinmk
Copy link
Contributor

s:UsesTerminal is not part of fugitive, so it must be some other plugin. The problem is likely a missing dict marker on the JobExit function.

https://github.com/neovim/neovim/wiki/Following-HEAD#20161212

This change was required for Vim compatibility.

@jc00ke
Copy link
Author

jc00ke commented Jan 17, 2017

@justinmk you're right, and when I add dict to this line in vim-dispatch-neovim I don't see the error. I'll move this over there.

Thanks!

@jc00ke jc00ke closed this as completed Jan 17, 2017
@jc00ke
Copy link
Author

jc00ke commented Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants