Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag a release of vim-markdown #57

Closed
nelstrom opened this issue Nov 15, 2013 · 5 comments
Closed

Tag a release of vim-markdown #57

nelstrom opened this issue Nov 15, 2013 · 5 comments

Comments

@nelstrom
Copy link
Contributor

I'd like to declare vim-markdown as a dependency for my vim-markdown-folding plugin. VimFlavor can only require plugins if:

  1. they are hosted on github
  2. they have version tags

Could you tag the current release of vim-markdown so that I can declare this dependency?

@tpope
Copy link
Owner

tpope commented Nov 15, 2013

Can you a "Synchronize with upstream" patch that fixes things to match up with what shipped with Vim 7.4 (probably just a couple of header tweaks)? I'll tag that as an official release.

@nelstrom
Copy link
Contributor Author

The version that shipped with Vim 7.4 has this header:

" Vim syntax file
" Language:     Markdown
" Maintainer:   Tim Pope <vimNOSPAM@tpope.org>
" Filenames:    *.markdown
" Last Change:  2013 May 30

The last commit before May 30th was 451eef, on May 27th. There's only been one patch since then: allow spaces after ```.

Does this patch do what you asked for? I created a headers-for-vim-7.4 branch in my fork, which omits the patch to allow spaces after ```.

@tpope
Copy link
Owner

tpope commented Dec 17, 2013

Yep, perfect. Sorry to leave it hanging for a month.

On Sat, Nov 16, 2013 at 11:54 AM, Drew Neil notifications@github.comwrote:

The version that shipped with Vim 7.4 has this header:

" Vim syntax file
" Language: Markdown
" Maintainer: Tim Pope vimNOSPAM@tpope.org
" Filenames: *.markdown
" Last Change: 2013 May 30

The last commit before May 30th was 451eefhttps://github.com/tpope/vim-markdown/commit/451eefb9b2e30bdba0adabb648f05a57fe726591,
on May 27th. There's only been one patch since then: allow spaces after

.

Does this patch<https://github.com/nelstrom/vim-markdown/commit/a1269743664a9dfc395047ba0ac9d285d860e38e>do what you asked for? I created a
headers-for-vim-7.4<https://github.com/nelstrom/vim-markdown/commits/headers-for-vim-7.4>branch in my fork, which omits the patch to allow
spaces after ```<https://github.com/tpope/vim-markdown/commit/55b49cad42efc450415880215c2922c643162356>
.

—
Reply to this email directly or view it on GitHub<https://github.com/tpope/vim-markdown/issues/57#issuecomment-28630582>
.

@tpope tpope closed this as completed Dec 17, 2013
@nelstrom
Copy link
Contributor Author

Thanks. Unfortunately, VimFlavor doesn't like the format of the vim7.4 tag. VimFlavor requires tags that follow the versioning policies of rubygems, like "1.1", "2.0" etc.

@tpope
Copy link
Owner

tpope commented Dec 18, 2013

Grr, okay.

On Tue, Dec 17, 2013 at 5:52 PM, Drew Neil notifications@github.com wrote:

Thanks. Unfortunately, VimFlavor doesn't like the format of the vim7.4https://github.com/tpope/vim-markdown/tree/vim7.4tag. VimFlavor requires tags that follow the versioning
policies of rubygemshttps://www.relishapp.com/kana/vim-flavor/docs/flavorfile/version-constraint,
like "1.1", "2.0" etc.


Reply to this email directly or view it on GitHubhttps://github.com//issues/57#issuecomment-30799950
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants