Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve fish as 'shell' for Vim 7.4.276 or later #128

Merged
merged 1 commit into from Sep 6, 2016
Merged

Preserve fish as 'shell' for Vim 7.4.276 or later #128

merged 1 commit into from Sep 6, 2016

Conversation

jamessan
Copy link
Contributor

@jamessan jamessan commented Sep 1, 2016

As of 7.4.276, Vim understands how to run commands in subshells when
'shell' is fish. This fixes the most common problems with running
external commands from Vim.

Plugins may still need to accommodate for fish, but fixing the cognitive
dissonance of having the user's shell changed outweighs the benefit to
lazy plugin writers.

As of 7.4.276, Vim understands how to run commands in subshells when
'shell' is fish.  This fixes the most common problems with running
external commands from Vim.

Plugins may still need to accommodate for fish, but fixing the cognitive
dissonance of having the user's shell changed outweighs the benefit to
lazy plugin writers.
@tpope tpope merged commit 4b75359 into tpope:master Sep 6, 2016
@jsatk
Copy link
Sponsor

jsatk commented Aug 20, 2018

I believe this commit causes some issues with tools like Dispatch. See here: tpope/vim-dispatch#243 (comment).

@jamessan are you able to get Dispatch to work in Vim 8 with Fish shell?

@tpope
Copy link
Owner

tpope commented Aug 20, 2018

Other plugins, even ones I wrote, are not Sensible's problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants