Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace isort, flake8, and pyupgrade with ruff #131

Merged
merged 8 commits into from
Aug 14, 2023
Merged

Replace isort, flake8, and pyupgrade with ruff #131

merged 8 commits into from
Aug 14, 2023

Conversation

tpvasconcelos
Copy link
Owner

@tpvasconcelos tpvasconcelos commented Aug 14, 2023

See: https://github.com/charliermarsh/ruff

image

Applied as many rules as possible from https://beta.ruff.rs/docs/rules/#ruff-specific-rules-ruf but left a few comments out for now as it would be too much work to refactor every single flagged case.

solves #115

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023

Codecov Report

Patch coverage: 82.60% and project coverage change: +18.31% 🎉

Comparison is base (a3e8193) 68.12% compared to head (ee627bc) 86.43%.
Report is 1 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #131       +/-   ##
===========================================
+ Coverage   68.12%   86.43%   +18.31%     
===========================================
  Files          11       10        -1     
  Lines         389      376       -13     
  Branches       66       66               
===========================================
+ Hits          265      325       +60     
+ Misses        115       39       -76     
- Partials        9       12        +3     
Flag Coverage Δ
unittests 86.43% <82.60%> (+18.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/ridgeplot/_utils.py 97.72% <ø> (-0.06%) ⬇️
src/ridgeplot/_ridgeplot.py 57.14% <57.14%> (+25.56%) ⬆️
src/ridgeplot/_figure_factory.py 81.25% <80.00%> (+48.43%) ⬆️
src/ridgeplot/_colors.py 96.55% <100.00%> (-0.06%) ⬇️
src/ridgeplot/_kde.py 74.07% <100.00%> (-0.93%) ⬇️
src/ridgeplot/_testing.py 100.00% <100.00%> (ø)
src/ridgeplot/_types.py 100.00% <100.00%> (ø)
src/ridgeplot/datasets/__init__.py 86.66% <100.00%> (-1.57%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from simplify-interactive-plots-in-docs to main August 14, 2023 15:01
@tpvasconcelos tpvasconcelos merged commit 0705f9b into main Aug 14, 2023
14 of 15 checks passed
@tpvasconcelos tpvasconcelos deleted the ruff branch August 14, 2023 15:53
@tpvasconcelos tpvasconcelos restored the ruff branch October 26, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants