Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to PDF files are wrong #146

Closed
MalikZohaib opened this issue Feb 17, 2023 · 1 comment
Closed

Link to PDF files are wrong #146

MalikZohaib opened this issue Feb 17, 2023 · 1 comment

Comments

@MalikZohaib
Copy link

MalikZohaib commented Feb 17, 2023

Hi,
Links to all indexed pdfs files in search results are leading to 404 even though pdf files exists. I tried to debug it and found that here https://github.com/tpwd/ke_search/blob/master/Classes/Lib/SearchHelper.php#L251 file path is passed through rawurlencode which encodes the whole url of pdf while it should have to encode only title of the pdf.

Here is an example of path before and after passing through L251.
image

@christianbltr
Copy link
Member

Thanks, the patch is merged and the fix will be in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants