Keep logging level when using tqdm logger redirect #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serene-Arc
force-pushed
the
logging_level_fix
branch
from
f661254
to
38adc5f
Compare
This was referenced Dec 1, 2022
|
This seems like a very simple change and this PR would be very useful (not supporting the default level strongly limits logging redirection at the moment). |
Serene-Arc
force-pushed
the
logging_level_fix
branch
from
38adc5f
to
e4f7a7c
Compare
|
@tfardet done! rebased off master. This isn't the only PR with these changes, fyi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the logging redirect. When using it, it removes the level of the associated logger that it is superseding, resulting in any verbosity setting being ignored from that point on. This is just a simple fix to carry over the logging level to the new logger object.