inherit handler level in logging redirect #1333
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #1272 Looks good to me |
|
My PR #1362 is also a duplicate of this I think |
kingarrrt
force-pushed
the
master
branch
4 times, most recently
from
3fd948e
to
0c65461
Compare
|
Updated with signed commit. Please review. |
|
@casperdcl update? |
|
It's really just a oneliner to fix this issue and the PR still not accepted (after years of reported issues and multiple similar unreviewed PRs) then the point has come that I sadly have to ditch tqdm. It's not a minor issue, logging is really important, and tqdm messes it all up. Please review |
|
Can someone else take over this review from @casperdcl ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handler level should be inherited in logging redirect