Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When 'index' or 'columns' is passed as pandas axis, convert to corres… #570

Merged
merged 2 commits into from
Sep 10, 2018

Conversation

gsganden
Copy link
Contributor

…ponding int

  • I have visited the source website, and in particular
    read the known issues
  • I have searched through the issue tracker for duplicates
  • I have mentioned version numbers, operating system and
    environment, where applicable:
    import tqdm, sys
    print(tqdm.__version__, sys.version, sys.platform)
  • If applicable, I have mentioned the relevant/related issue(s)

@codecov-io
Copy link

codecov-io commented Jun 26, 2018

Codecov Report

Merging #570 into master will decrease coverage by 0.57%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #570      +/-   ##
=========================================
- Coverage   99.27%   98.7%   -0.58%     
=========================================
  Files           8       8              
  Lines         692     696       +4     
  Branches      123     125       +2     
=========================================
  Hits          687     687              
- Misses          3       5       +2     
- Partials        2       4       +2

@casperdcl casperdcl self-assigned this Jun 27, 2018
@casperdcl casperdcl added p3-enhancement 🔥 Much new such feature submodule ⊂ Periphery/subclasses to-review 🔍 Awaiting final confirmation labels Jun 27, 2018
@gsganden
Copy link
Contributor Author

gsganden commented Aug 9, 2018

A performance test failed on Python 2.7. I'm not sure whether or how to address this issue.

@chengs
Copy link
Contributor

chengs commented Aug 22, 2018

the error in performance test is not caused by your code.
I think your code is fine
.

@casperdcl casperdcl added to-merge ↰ Imminent and removed to-review 🔍 Awaiting final confirmation labels Aug 22, 2018
…ponding int

Add 'index' and 'columns' to `axis` arguments

closes tqdm#570
@casperdcl casperdcl force-pushed the bugfix/convert-pandas-axis-to-int branch from a7532f8 to c0eaf5d Compare September 10, 2018 18:10
@casperdcl casperdcl merged commit c0eaf5d into tqdm:master Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-enhancement 🔥 Much new such feature submodule ⊂ Periphery/subclasses to-merge ↰ Imminent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants