tqdm: fix casting to boolean to mimic self.iterable #694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have hit an issue described in #353 today with what can be boiled down to:
This is a stab at fixing it: it will make the
tqdm
wrapper behave in exactly the same way as the wrappedself.iterable
when cast to boolean. Admittedly, it could be made more intelligent by comparing the current position to the total length if it is known, but that would complicate things and I wanted to start with a simple solution.read the known issues
environment, where applicable: