fix: keras.TqdmCallback: batch_bar does not always exist on_train_end #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firatozdemir
force-pushed
the
master
branch
from
03c362a
to
6ab147b
Compare
casperdcl
approved these changes
Feb 5, 2024
casperdcl
added
p0-bug-critical ☢
|
Thanks! Sorry for the delay... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when
verbose==2, TqdmCallback object does not definebatch_barinside__init__but only inon_epoch_begin.If
keras.model.fitis run after all training epochs are finished,on_train_endthrows error becauseself.batch_bardoes not exist.Fix is to check if batch_bar attribute exists before closing it, similar to how it is handled inside
on_epoch_begin.