Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix temporary bar displaying with tqdm_notebook #174

Merged
merged 1 commit into from
Jun 2, 2016
Merged

Conversation

lrq3000
Copy link
Member

@lrq3000 lrq3000 commented Jun 2, 2016

Should fix issue reported by @wernight in issue #170.

BTW, I noticed a weird issue about old widgets bars reappearing after reloading the notebook, but we can't do anything about it because it seems it's ipywidgets fault. I reported it at jupyter-widgets/ipywidgets#624.

Signed-off-by: Stephen L. <lrq3000@gmail.com>
@lrq3000 lrq3000 assigned lrq3000 and unassigned lrq3000 Jun 2, 2016
@codecov-io
Copy link

codecov-io commented Jun 2, 2016

Current coverage is 100%

Merging #174 into master will not change coverage

@@             master       #174   diff @@
==========================================
  Files             8          8          
  Lines           447        447          
  Methods           0          0          
  Messages          0          0          
  Branches         80         80          
==========================================
  Hits            447        447          
  Misses            0          0          
  Partials          0          0          

Powered by Codecov. Last updated by af1d7c5...df7f18f

@coveralls
Copy link

coveralls commented Jun 2, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling df7f18f on notebook-fix into af1d7c5 on master.

@casperdcl
Copy link
Sponsor Member

yes, this is what the gui parameter is now used for - inheriting but suppressing output.

@casperdcl casperdcl merged commit df7f18f into master Jun 2, 2016
@lrq3000
Copy link
Member Author

lrq3000 commented Jun 2, 2016

Ok great! :D I should have done it like this from the beginning, it would have been way simpler!
Thank you Casper for the review and merge :)

@casperdcl casperdcl deleted the notebook-fix branch June 2, 2016 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants