Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapped monospacing around example progress bar #205

Closed
wants to merge 2 commits into from

Conversation

CrazyPython
Copy link
Contributor

Looks better, more accurate representation of progress bar.

Looks better, more accurate representation of progress bar.
@coveralls
Copy link

coveralls commented Jul 21, 2016

Coverage Status

Coverage remained the same at 81.404% when pulling 7e118d2 on CrazyPython:CrazyPython-patch-1 into edefb05 on tqdm:master.

@codecov-io
Copy link

codecov-io commented Jul 21, 2016

Current coverage is 81.40% (diff: 100%)

Merging #205 into master will not change coverage

@@             master       #205   diff @@
==========================================
  Files             8          8          
  Lines           527        527          
  Methods           0          0          
  Messages          0          0          
  Branches         99         99          
==========================================
  Hits            429        429          
  Misses           98         98          
  Partials          0          0          

Powered by Codecov. Last update edefb05...63e3d2a

@lrq3000
Copy link
Member

lrq3000 commented Jul 21, 2016

Thank's for the better formatting. We should then also remove the escapes because they aren't necessary anymore:

76%\|████████████████████\ \| 7641/10000 [00:34<00:10, 222.22 it/s]

yay open-source
@CrazyPython
Copy link
Contributor Author

@lrq3000 boom! glad to help you out!

@coveralls
Copy link

coveralls commented Jul 22, 2016

Coverage Status

Coverage remained the same at 81.404% when pulling 63e3d2a on CrazyPython:CrazyPython-patch-1 into edefb05 on tqdm:master.

@casperdcl
Copy link
Sponsor Member

? does this work? I was sure in the past either github or pypi condensed spaces even in mono...

@CrazyPython
Copy link
Contributor Author

@casperdcl huh?

@CrazyPython
Copy link
Contributor Author

@casperdcl why hasn't codecov/changes finished building yet? :/

@CrazyPython
Copy link
Contributor Author

Do the same in PyPI.

@CrazyPython
Copy link
Contributor Author

@casperdcl why hasn't codecov completed yet? I think it's bugged. you should restart it and/or disable the requiredness of codecov. I don't think code coverage should ever block a PR.

@casperdcl casperdcl mentioned this pull request Jul 23, 2016
@casperdcl
Copy link
Sponsor Member

merged in #212

@casperdcl casperdcl closed this Jul 23, 2016
@casperdcl
Copy link
Sponsor Member

I recall we added two different coverage methods because different people were comfortable with different ones. In the past I've also noticed interesting differences between the stats reported. each seems to have its advantages. just tried resetting the codecov hook. we'll see

@CrazyPython CrazyPython deleted the CrazyPython-patch-1 branch July 23, 2016 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants