-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrapped monospacing around example progress bar #205
Conversation
Looks better, more accurate representation of progress bar.
Current coverage is 81.40% (diff: 100%)@@ master #205 diff @@
==========================================
Files 8 8
Lines 527 527
Methods 0 0
Messages 0 0
Branches 99 99
==========================================
Hits 429 429
Misses 98 98
Partials 0 0
|
Thank's for the better formatting. We should then also remove the escapes because they aren't necessary anymore:
|
yay open-source
@lrq3000 boom! glad to help you out! |
? does this work? I was sure in the past either github or pypi condensed spaces even in mono... |
@casperdcl huh? |
@casperdcl why hasn't |
Do the same in PyPI. |
@casperdcl why hasn't codecov completed yet? I think it's bugged. you should restart it and/or disable the requiredness of codecov. I don't think code coverage should ever block a PR. |
merged in #212 |
I recall we added two different coverage methods because different people were comfortable with different ones. In the past I've also noticed interesting differences between the stats reported. each seems to have its advantages. just tried resetting the codecov hook. we'll see |
Looks better, more accurate representation of progress bar.