Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster simple bar for perf test #257

Merged
merged 3 commits into from Sep 15, 2016
Merged

Faster simple bar for perf test #257

merged 3 commits into from Sep 15, 2016

Conversation

lrq3000
Copy link
Member

@lrq3000 lrq3000 commented Sep 2, 2016

Added trick described in 0346a4a to the simple bar in perf test. Didn't test if the bar was faster, but since this is exactly the same scenario it should also improve the speed.

Signed-off-by: Stephen L. <lrq3000@gmail.com>
@lrq3000 lrq3000 added the p3-enhancement 🔥 Much new such feature label Sep 2, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.776% when pulling 692b644 on faster-perf-test into 02cbd9c on master.

Signed-off-by: Stephen L. <lrq3000@gmail.com>
@lrq3000 lrq3000 added the to-review 🔍 Awaiting final confirmation label Sep 3, 2016
Signed-off-by: Stephen L. <lrq3000@gmail.com>
@lrq3000
Copy link
Member Author

lrq3000 commented Sep 3, 2016

Ok I'm done here. I don't want to enhance this simple_bar further because it should not become a duplicate of tqdm_bare, so any enhancement will go exclusively there (except if it's a performance enhancement, but I doubt we can do much more than that).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.776% when pulling 66aa8d2 on faster-perf-test into 02cbd9c on master.

@codecov-io
Copy link

codecov-io commented Sep 3, 2016

Current coverage is 90.56% (diff: 100%)

Merging #257 into master will not change coverage

@@             master       #257   diff @@
==========================================
  Files             7          7          
  Lines           477        477          
  Methods           0          0          
  Messages          0          0          
  Branches         85         85          
==========================================
  Hits            432        432          
  Misses           44         44          
  Partials          1          1          

Powered by Codecov. Last update 02cbd9c...16bbb21

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.776% when pulling 16bbb21 on faster-perf-test into 02cbd9c on master.

@lrq3000 lrq3000 mentioned this pull request Sep 6, 2016
4 tasks
@lrq3000 lrq3000 merged commit 0243499 into master Sep 15, 2016
@lrq3000 lrq3000 deleted the faster-perf-test branch September 15, 2016 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-enhancement 🔥 Much new such feature to-review 🔍 Awaiting final confirmation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants