New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix file
default value (ease redirection)
#293
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
=========================================
Coverage ? 92.05%
=========================================
Files ? 7
Lines ? 579
Branches ? 131
=========================================
Hits ? 533
Misses ? 44
Partials ? 2 |
I checked that redirection works correctly with this code (maybe we should add a unit test?):
|
casperdcl
force-pushed
the
master
branch
4 times, most recently
from
October 31, 2016 02:34
8cade97
to
a65e347
Compare
This was referenced Dec 29, 2016
casperdcl
force-pushed
the
file-default-fix
branch
from
May 1, 2017 16:09
63433ca
to
186a8dd
Compare
casperdcl
force-pushed
the
file-default-fix
branch
from
May 28, 2017 23:21
186a8dd
to
22fe33c
Compare
casperdcl
force-pushed
the
file-default-fix
branch
from
May 29, 2017 00:30
f652d07
to
204fc43
Compare
This was referenced May 29, 2017
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #275.
file
argument is now set to None and defined at instanciation inside__init__()
(instead of at class import). This should ease file redirection (as long assys.stdout
is redirected before tqdm instanciation, it should be fine).TODO:
file=None
and set defaultself.fp=sys.stderr
inside init. Same fortqdm.write()
(and other methods/submodules?). This will allow users to redirect sys.stderr before instanciating tqdm, without needing to supply the new redirection to tqdm.TODO in a separate PR
resiliency-io-error
:self.fp.write()
(tqdm.move()
andstatus_printer
?) intry/except
block (this should not impact performances as the except block will only get evaluated if necessary). Theexcept
block should still display any error but as a non blocking message (using a newTqdmErrorMessage() class
?). Something like this: