Use ANSI escape to clear to end of line #729
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches from trying to remember the length of the previous output, and instead uses an ANSI sequence to clear to the end of the line. This fixes issue tqdm#728
|
ah but will this work on all systems? My guess is anything that doesn't support nested bars will also stop supporting single bars if we merge this. |
casperdcl
added
p4-enhancement-future 🧨
|
Which systems did you have in mind? Maybe we can switch this based on termcap info or something? Without this, I get junk output on my screen on LInux/gnome-terminal. |
|
vis nested progress bars under https://github.com/tqdm/tqdm/#faq-and-known-issues |
|
thanks for your issues and PRs btw, just not sure about this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches from trying to remember the length of the previous output,
and instead uses an ANSI sequence to clear to the end of the line.
This fixes issue #728