Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Additional Base Functionality #787

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

inspectorG4dget
Copy link

Added functionality:
All prints now show the filename, function, line number, and description

  • I have visited the source website, and in particular
    read the known issues
  • I have searched through the issue tracker for duplicates
  • I have mentioned version numbers, operating system and
    environment, where applicable:
    import tqdm, sys
    print(tqdm.__version__, sys.version, sys.platform)
  • If applicable, I have mentioned the relevant/related issue(s)

Added functionality:
All prints now show the filename, function, line number, and description
TQDM now outputs the print time as well
Bar format has been ported over to printing
@casperdcl
Copy link
Sponsor Member

Maybe nice to have as an example of extending tqdm but don't really see this in core. Could you move this to the examples/ folder?

@casperdcl casperdcl self-assigned this Aug 8, 2019
@casperdcl casperdcl added question/docs ‽ Documentation clarification candidate submodule ⊂ Periphery/subclasses labels Aug 8, 2019
@inspectorG4dget
Copy link
Author

In fact, I've added my extensions to patch.py by subclassing the main class, so that it does not conflict with mainline development/API. The proper way to use this patch would therefore be from tqdm.patch import tqdm, print.

In any case, I will add some usage examples to show how this works

This is what the last commit should have been.
Robustified computing the numebr columns across *NIX and PC (by using a default for PC)
Removed commented out debug code
Added print functionality
Some basic refactoring for future maintenance
@codecov-io
Copy link

codecov-io commented Aug 26, 2019

Codecov Report

Merging #787 into master will increase coverage by 6.85%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
+ Coverage   85.56%   92.42%   +6.85%     
==========================================
  Files          15       11       -4     
  Lines         977      845     -132     
  Branches      169      150      -19     
==========================================
- Hits          836      781      -55     
+ Misses        136       60      -76     
+ Partials        5        4       -1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question/docs ‽ Documentation clarification candidate submodule ⊂ Periphery/subclasses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants