Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paper: Spell project names as they spell them #910

Merged
merged 2 commits into from Jun 6, 2020

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Mar 7, 2020

  • I have marked all applicable categories:
    • exception-raising fix
    • visual output fix
    • documentation modification
    • new feature
  • If applicable, I have mentioned the relevant/related issue(s)

Less important but also useful:

  • I have visited the source website, and in particular
    read the known issues
  • I have searched through the issue tracker for duplicates
  • I have mentioned version numbers, operating system and
    environment, where applicable:
    import tqdm, sys
    print(tqdm.__version__, sys.version, sys.platform)

References:

@hugovk hugovk requested a review from casperdcl as a code owner March 7, 2020 14:05
@codecov-io
Copy link

codecov-io commented Mar 7, 2020

Codecov Report

Merging #910 into paper will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            paper     #910   +/-   ##
=======================================
  Coverage   87.12%   87.12%           
=======================================
  Files          21       21           
  Lines        1212     1212           
  Branches      204      204           
=======================================
  Hits         1056     1056           
  Misses        138      138           
  Partials       18       18           

@hugovk hugovk changed the title Spell project names as they spell them Paper: Spell project names as they spell them Mar 7, 2020
@casperdcl casperdcl self-assigned this Mar 9, 2020
@casperdcl casperdcl added the question/docs ‽ Documentation clarification candidate label Mar 9, 2020
@casperdcl casperdcl added this to the v5.0.0 milestone Mar 9, 2020
@casperdcl casperdcl added this to Next Release in Casper Mar 9, 2020
@casperdcl casperdcl changed the base branch from master to paper March 9, 2020 12:51
@casperdcl
Copy link
Sponsor Member

I prefer code versions for everything, in which case we should change Jupyter to jupyter instead...

@@ -97,11 +97,11 @@ Supported features include:
terminals
- Support for custom rendering frontends, including:
* Command-line interface
* *Jupyter* HTML notebooks
* `matplotlib`
* Jupyter HTML notebooks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "Jupyter Notebook" as they spell it, drop "HTML"

@lrq3000
Copy link
Member

lrq3000 commented Apr 28, 2020

I am agnostic to the use of either the code version or the prose version of the names, as long as the same style is consistently used. Although I have a slight preference for the prose version, since the names are written in the context of a paper, but it doesn't really make a difference in either case IMO as long as the style is consistent.

@hugovk
Copy link
Contributor Author

hugovk commented Apr 28, 2020

My preference depends on the context: code style when writing code, or specifically talking about a command; prose style when talking about a project (how the project refers to themselves).

I agree about prose being more appropriate in the context of a paper.

@codecov-commenter
Copy link

Codecov Report

Merging #910 into paper will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            paper     #910   +/-   ##
=======================================
  Coverage   87.12%   87.12%           
=======================================
  Files          21       21           
  Lines        1212     1212           
  Branches      204      204           
=======================================
  Hits         1056     1056           
  Misses        138      138           
  Partials       18       18           

@casperdcl casperdcl merged commit e1db6f7 into tqdm:paper Jun 6, 2020
Casper automation moved this from Next Release to Done Jun 6, 2020
@casperdcl casperdcl mentioned this pull request Jun 6, 2020
76 tasks
@hugovk hugovk deleted the project-names branch June 6, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question/docs ‽ Documentation clarification candidate
Projects
Casper
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants