Exceptions #926
Merged
Exceptions #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperdcl
added
p2-bug-warning ⚠
- fixes (partially) #548
Codecov Report
@@ Coverage Diff @@
## devel #926 +/- ##
==========================================
+ Coverage 87.06% 87.07% +0.01%
==========================================
Files 21 21
Lines 1245 1246 +1
Branches 211 211
==========================================
+ Hits 1084 1085 +1
Misses 141 141
Partials 20 20 |
- reason for no auto-`close()` upon `Exception`
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close()on exceptionsclose()on notebooks since the user may have a shared bar which they'd like toreset()insteadnotebookbar