Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bash autocomplete base functionality #947

Merged
merged 9 commits into from
Apr 26, 2020
Merged

Bash autocomplete base functionality #947

merged 9 commits into from
Apr 26, 2020

Conversation

nishnash54
Copy link
Contributor

@nishnash54 nishnash54 commented Apr 25, 2020 •
edited by casperdcl

Integrated the core CLI options and the extra CLI options
Removed options with no CLI support

related: #858 #946

@nishnash54
base functionality
ada51e1 
- core CLI options + extra CLI options
- remove options with no CLI support
nishnash54
nishnash54 commented Apr 25, 2020
View reviewed changes
.meta/mkcompletion.py Outdated Show resolved Hide resolved
.meta/mkcompletion.py Outdated Show resolved Hide resolved
@nishnash54 nishnash54 changed the title base functionality Bash complete base functionality Apr 25, 2020
@nishnash54 nishnash54 changed the title Bash complete base functionality Bash autocomplete base functionality Apr 25, 2020
@casperdcl
Copy link
Sponsor Member

Thanks @nishnash54 for this - looks great!

@casperdcl casperdcl added p3-enhancement 🔥 Much new such feature question/docs ‽ Documentation clarification candidate submodule ⊂ Periphery/subclasses to-fix ⌛ In progress labels Apr 25, 2020
@nishnash54
test bash autocomplete args
aa1105d
@nishnash54
documentation
3becbb6 
- integrate with code
- add to readme/docs etc.
- remove file
nishnash54
nishnash54 commented Apr 26, 2020
View reviewed changes
Copy link
Contributor Author

@nishnash54 nishnash54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added basic tests and documentation for the auto complete script. Includes adding new arguments and updating docs and scripts accordingly.
Let me know how and where to integrate the changes in to the code base.

casperdcl
casperdcl reviewed Apr 26, 2020
View reviewed changes
.meta/docs.md Outdated Show resolved Hide resolved
casperdcl and others added 4 commits April 26, 2020 14:00
@casperdcl
don't complete after user-specified options
276149e
@nishnash54
Merge remote-tracking branch 'upstream/completion' into completion
8cdbbf7
@nishnash54
tests
b466398 
- test auto complete script
- remove redundant test
@nishnash54
docs
b3d32b1 
- updated CONTRIBUTING.md
- removed sample docs
@casperdcl casperdcl merged commit 844bfee into tqdm:completion Apr 26, 2020
casperdcl added a commit that referenced this pull request May 2, 2020
@casperdcl
Merge branch 'completion' into devel
bf6563d 
- closes #946
- closes #947
- fixes #858
@casperdcl casperdcl mentioned this pull request May 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl casperdcl left review comments

Assignees

@casperdcl casperdcl

@nishnash54 nishnash54

Labels
p3-enhancement 🔥 Much new such feature question/docs ‽ Documentation clarification candidate submodule ⊂ Periphery/subclasses to-fix ⌛ In progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nishnash54 @casperdcl