Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#148] Improve batching #210

Closed
wants to merge 1 commit into from
Closed

Conversation

lierdakil
Copy link
Contributor

@lierdakil lierdakil commented Jun 1, 2023

Description

Problem: a lot of initial setup in tests can be batched, considerably speeding up network tests.

Solution: do that.

This replaces individual address setup with a structure in some tests. This is a little bit wasteful, but barely so, as addresses should be reused.

Related issue(s)

Resolves #148

✅ Checklist for your Pull Request

Related changes (conditional)

  • Tests

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from
      silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog unless I am sure my changes are
      not essential.

Stylistic guide (mandatory)

✓ Release Checklist

  • I updated the Gas / Transaction costs table in the README.
  • I updated the version number in package.yaml.
  • I updated the changelog and moved everything
    under the "Unreleased" section to a new section for this release version.
  • (After merging) I created a new entry in the releases page,
    with a summary of all user-facing changes.
    • I made sure a tag was created using the format vX.Y.Z
    • I attached the following artifacts from buildkite
      • stablecoin-client
      • stablecoin.fa1.2.tz
      • stablecoin.tz

Problem: a lot of initial setup in tests can be batched, considerably
speeding up network tests.

Solution: do that.

This replaces individual address setup with a structure in some tests.
This is a little bit wasteful, but barely so, as addresses should be
reused.
@lierdakil lierdakil requested a review from pasqu4le July 4, 2023 13:35
@lierdakil lierdakil self-assigned this Jul 4, 2023
@lierdakil
Copy link
Contributor Author

@pasqu4le I'm pinging you for review, but as I mentioned previously, this doesn't seem to be worth it, there's barely any difference.

image
image
image

If there's any improvement at all, it's entirely drowned out by the noise.

@pasqu4le
Copy link
Contributor

pasqu4le commented Aug 1, 2023

I'm closing this as the changes make little difference, then

@pasqu4le pasqu4le closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tests to use tasty + nettest interface + batching
2 participants