Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PWA manifest plugin and default configuration + Updated README #10

Closed
wants to merge 1 commit into from

Conversation

rubenaguadoc
Copy link

@rubenaguadoc rubenaguadoc commented Jan 28, 2019

Maybe this is useful

@tr1s tr1s self-assigned this Jan 29, 2019
@tr1s
Copy link
Owner

tr1s commented Jan 29, 2019

I was playing around with it, but after some reading, I think I'm going to opt out of this PR. The webpack-pwa-manifest is kind of abandoned, and I don't want to add extra complexity and confusion that might not get resolved in the future.

The idea here was that I'll prepare the boilerplate for people that want to take the full plunge into it themselves.

I'd consider adding in a barebones manifest.json for the sake of it, or if there's a more robust way to inject it that would be nice. I'll look into it more and feel to do the same and let me know your thoughts.

@tr1s tr1s closed this Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants