Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle: Fix executable bit #112

Merged
merged 1 commit into from May 25, 2023
Merged

gradle: Fix executable bit #112

merged 1 commit into from May 25, 2023

Conversation

5HT2
Copy link
Contributor

@5HT2 5HT2 commented May 25, 2023

This fixes the gradle compose script not being marked as executable for Linux and macOS systems.

This fixes the gradle compose script not being marked as executable for Linux and macOS systems.
@what-the-diff
Copy link

what-the-diff bot commented May 25, 2023

PR Summary

  • Changed gradlecw file to executable
    This update improves the ease of using gradlecw by making it an executable file.

@sonarcloud
Copy link

sonarcloud bot commented May 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tr7zw tr7zw merged commit a28f884 into tr7zw:1.19.4 May 25, 2023
2 checks passed
@tr7zw
Copy link
Owner

tr7zw commented May 25, 2023

This problem probably stretches over all my repos. I work on windows, and the CI file starts with a chmod +x ./gradlecw. But doesn't hurt to fix it I guess.

@tr7zw
Copy link
Owner

tr7zw commented May 25, 2023

@5HT2 Also fyi, you copied the This fixes the gradle compose script not being marked as executable for Linux and macOS systems. into the other PR's from other repos. Gradle compose is my own custom tooling, in the other repos it's the normal gradle wrapper, not "compose".

@5HT2
Copy link
Contributor Author

5HT2 commented May 25, 2023

@5HT2 Also fyi, you copied the This fixes the gradle compose script not being marked as executable for Linux and macOS systems. into the other PR's from other repos. Gradle compose is my own custom tooling, in the other repos it's the normal gradle wrapper, not "compose".

Oh god that's embarrassing. Thank you for pointing it out, I realized earlier that gradle compose was something I had not seen before :p I should have changed the commit message back to just gradle.

I've just been porting mods for myself and fixing the chmod bits along the way when people forget to enable it, I didn't pay too much attention when making the commits 😭

@tr7zw
Copy link
Owner

tr7zw commented May 25, 2023

Happens :D. I just wrote that small "compose" wrapper around the gradle wrapper that spawns data managed at https://github.com/tr7zw/ModComposeTemplate/tree/1.19.4 using the https://github.com/tr7zw/EntityCulling/blob/1.19.4/gradle-compose.yml file. Otherwise I'd go insane managing all the Forge/Fabric dependencies/CI scripts/Gradle files/small utility classes/etc over 10? projects with 6+ version branches each. In the end I'm just one person doing this for fun^^.

@5HT2
Copy link
Contributor Author

5HT2 commented May 26, 2023

that's very cool !! thank you for explaining what it is c:

tr7zw added a commit that referenced this pull request Nov 23, 2023
gradle: Fix executable bit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants