Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#108: fix confirmation screen always popping up when using Itemswapper on server #112

Merged
merged 3 commits into from Mar 18, 2023

Conversation

AdvancedWipe
Copy link
Contributor

  • add a cache file which saves the ip-address of the server the player is currently on, if the player accepts the warning. They will no longer get the warning for this server
  • if the player denies the warning (will not accept), the mod will be disabled for this server. If the player now presses the hotkey, a message will be displayed that they disabled the mod for this server.

…wapper on server

* add a cache file which saves the ip-address of the server the player is currently on, if the player accepts the warning. They will no longer get the warning for this server
* if the player denies the warning (will not accept), the mod will be disabled for this server. If the player now presses the hotkey, a message will be displayed that they disabled the mod for this server
@tr7zw
Copy link
Owner

tr7zw commented Dec 30, 2022

There should be a checkmark/extra button for permanently accepting an option.
Some other things:

  • perma disabling the mod for a server with no way to undo it(except for deleting the line in the file) might not be a good idea. Keeping the "no" option only for the current session might be better
  • Showing a small info in the actionbar/chat when the mod is still not on the server and the local file was used to skip the confirmation screen might be nice(so just once on the first use each play session)

@tr7zw tr7zw changed the base branch from 1.19 to 1.19.3 March 18, 2023 00:06
@tr7zw tr7zw merged commit a27ce49 into tr7zw:1.19.3 Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants