Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistency in documentation #184

Merged
merged 1 commit into from Oct 27, 2023
Merged

Fix inconsistency in documentation #184

merged 1 commit into from Oct 27, 2023

Conversation

Silveere
Copy link
Contributor

I noticed that the type for Palette Modification and List Modification resources in the documentation were palette_modification and list_modification respectively, meanwhile the example JSON as well as the resource loader code say they should be paletteModification and listModification.

@what-the-diff
Copy link

what-the-diff bot commented Oct 27, 2023

PR Summary

  • Modification in Palette Definitions
    In '4. Palette Modifications.md', there's a change in the way we name 'type'. We used to call it 'palette_modification', now it's updated to 'paletteModification' to enhance consistency.

  • Modification in List Definitions
    Similarly, in '5. List Modifications.md', the 'type' key name has also been improved. It changed from 'list_modification' to 'listModification'. This makes our code cleaner and easier to understand.

@tr7zw
Copy link
Owner

tr7zw commented Oct 27, 2023

Oops correct.

@tr7zw tr7zw merged commit c8984d2 into tr7zw:1.20.2 Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants