Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block entities from Enhanced Block Entities mod do not get culled #41

Closed
BobdaBiscuit opened this issue Sep 21, 2021 · 2 comments
Closed

Comments

@BobdaBiscuit
Copy link

Hey, I've got a small issue report for a soft-incompatibility.

Testing Entity Culling 1.3.3 with Enhanced Block Entities 0.5+1.17 has blocks such as chests not get culled when occluded, or when outside the 64 block render distance. Remaining visible the entire time.

Disabling chest optimizations on EBE causes Entity Culling to correctly remove chests again.

Thanks for your time.

@tr7zw
Copy link
Owner

tr7zw commented Sep 21, 2021

Thats because of what the Enhanced Block Entities mod does. It replaces the Block-Entity Renderer of chests with a static one. Therefore it's not a rendered Block-Entity any more and won't get culled(since there is no reason for that, because it behaves like for example a fencepost). So keep the chest optimizations active, since it will increase the normal performance, and reduce the amount of things that this mod needs to calculate, giving a net gain over just entity culling.

@tr7zw tr7zw closed this as completed Sep 21, 2021
@BobdaBiscuit
Copy link
Author

Righto, thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants