Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

本番ビルドでヘッダーのロゴが表示できてない #156

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

mehm8128
Copy link
Member

@mehm8128 mehm8128 commented Jun 18, 2024

型エラーになったので直した

@mehm8128 mehm8128 self-assigned this Jun 18, 2024
@mehm8128 mehm8128 marked this pull request as ready for review June 19, 2024 11:57
@mehm8128 mehm8128 requested a review from Pugma June 19, 2024 11:58
Copy link
Collaborator

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この一点だけ確認をお願いします!

:src="
isMobile
? '/@/assets/traP_logo_icon.svg'
: '/@/assets/traP_logo_blue.svg'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここなんですが、
/@/assets/traP_logo_icon.svg -> /assets/traP_logo_icon.svg
とするだけで今回の問題が解決しそうな気がしました…

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

やってみたけど駄目そう

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ〜、これpublicフォルダに入ってるやつじゃないからこうなっちゃうんですね
ちょっとそのあたりちゃんと把握できていませんでした…

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

今のままでよさそうならapproveほしいです:pray:

Copy link
Collaborator

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okです!
ありがとうございます

@mehm8128 mehm8128 merged commit dfb300e into master Jun 21, 2024
8 checks passed
@mehm8128 mehm8128 deleted the fix/header_logo branch June 21, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants