Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang from 1.20.7-alpine to 1.21.0-alpine #1927

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 9, 2023

Bumps golang from 1.20.7-alpine to 1.21.0-alpine.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps golang from 1.20.7-alpine to 1.21.0-alpine.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@logica0419
Copy link
Member

Goのメジャーバージョンアップデートが来た時は、

  • go.modのバージョン更新
  • Actionsで使うGoバージョンの更新

の2つをして、新バージョンで問題なく動くかCIで確かめる必要があります
やってくれる人はいませんか?

@ikura-hamu
Copy link
Member

しました。

@motoki317
Copy link
Member

わざわざ .go-version っていうファイルを通してるけど、使ってるのは actions/setup-go だけなので、
https://github.com/actions/setup-go#getting-go-version-from-the-gomod-file
のように go.mod からバージョンを読ませてもいいかもしれない

@ikura-hamu
Copy link
Member

よさそう。変えちゃってもいいですか

@logica0419
Copy link
Member

いいyp

@logica0419
Copy link
Member

一応ref
https://go.dev/doc/toolchain

Copy link
Member

@logica0419 logica0419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそう
ありがとう〜!

@logica0419 logica0419 merged commit e8837c6 into master Aug 15, 2023
5 checks passed
@logica0419 logica0419 deleted the dependabot/docker/golang-1.21.0-alpine branch August 15, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants