GIFのリサイズのDisposalの扱いを、仕様と実情に則したものに #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
logica0419
commented
Dec 14, 2023
logica0419
commented
- Imagemagickを抹殺 #2143 にて、Disposalの仕様を勘違いしていて正しく実装できてなかったので実装し直した
- 仕様に忠実に実装したところ、実情に則していない部分が出てしまったので、 https://github.com/themadcreator/gifler など参考に実情に合った実装を行った
- テストケースを追加した
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.