Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade typescript to 5.0.4, vue to 3.3.4, pinia to 2.1.3, @pinia/testing to 0.1.2 #3990

Merged
merged 8 commits into from Jul 13, 2023

Conversation

ras0q
Copy link
Member

@ras0q ras0q commented May 31, 2023

ref: #3810

  • ⬆️ upgrade typescript to 5.0.4
  • ⬆️ upgrade vue, pinia for fixing type-check

@ras0q
Copy link
Member Author

ras0q commented May 31, 2023

めちゃめちゃ落ちました:sad:

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5f8edcf) 86.34% compared to head (79f198a) 86.34%.

❗ Current head 79f198a differs from pull request most recent head a29ccce. Consider uploading reports for the commit a29ccce to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3990   +/-   ##
=======================================
  Coverage   86.34%   86.34%           
=======================================
  Files          66       66           
  Lines        4709     4709           
  Branches      563      563           
=======================================
  Hits         4066     4066           
  Misses        637      637           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ras0q ras0q changed the title upgrade typescript to 5.0.4, vue to 3.3.0, pinia to 2.1.3, @pinia/testing to 0.1.2 upgrade typescript to 5.0.4, vue to 3.3.4, pinia to 2.1.3, @pinia/testing to 0.1.2 May 31, 2023
@ras0q
Copy link
Member Author

ras0q commented May 31, 2023

e2eのエラーはこれ
cypress-io/cypress#26203

@ras0q ras0q self-assigned this May 31, 2023
@sapphi-red
Copy link
Member

よさそうだけど先にViteと@vitejs/plugin-vueとvue-tscあげたほうがよさそうかもです
https://blog.vuejs.org/posts/vue-3-3#:~:text=When%20upgrading%20to,or%20vue%2Dcli

Copy link
Member

@mehm8128 mehm8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうな気がします

@ras0q
Copy link
Member Author

ras0q commented Jun 6, 2023

#3927 を先にマージする

@ras0q
Copy link
Member Author

ras0q commented Jul 11, 2023

マージします
コンフリクトしてた

@ras0q ras0q enabled auto-merge July 12, 2023 15:24
@ras0q ras0q requested a review from mehm8128 July 12, 2023 15:25
@ras0q ras0q disabled auto-merge July 12, 2023 23:20
@ras0q ras0q merged commit af0d165 into master Jul 13, 2023
8 checks passed
@ras0q ras0q deleted the upgrade/typescript-vue-pinia branch July 13, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants