Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typeが"empty"のOGPデータを無視するように #3994

Merged
merged 2 commits into from
Jun 18, 2023

Conversation

logica0419
Copy link
Member

@logica0419 logica0419 commented Jun 3, 2023

refs traPtitech/traQ#1443

traPtitech/traQ#1833 と同時に適用する必要がある

@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c7d4244) 86.34% compared to head (b2ce881) 86.34%.

❗ Current head b2ce881 differs from pull request most recent head f36b64f. Consider uploading reports for the commit f36b64f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3994   +/-   ##
=======================================
  Coverage   86.34%   86.34%           
=======================================
  Files          66       66           
  Lines        4709     4709           
  Branches      563      563           
=======================================
  Hits         4066     4066           
  Misses        637      637           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ras0q ras0q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動作確認はしてないけど見ました、よさそう

Copy link
Member

@mehm8128 mehm8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうです

Copy link
Member

@ras0q ras0q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそうです
OGPないときのレスポンスも早くなってていい感じ
image

@logica0419 logica0419 merged commit a580415 into master Jun 18, 2023
8 checks passed
@logica0419 logica0419 deleted the ignore-empty-typed-ogp branch June 18, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants