Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showcaseへのリンクをneoshowcaseのリンクで置き換え #4005

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

mehm8128
Copy link
Member

@mehm8128 mehm8128 commented Jul 2, 2023

No description provided.

@mehm8128 mehm8128 self-assigned this Jul 2, 2023
@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a580415) 86.34% compared to head (f3ad714) 86.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4005   +/-   ##
=======================================
  Coverage   86.34%   86.34%           
=======================================
  Files          66       66           
  Lines        4709     4709           
  Branches      563      563           
=======================================
  Hits         4066     4066           
  Misses        637      637           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nokhnaton
Copy link
Contributor

NeoShowcaseへのリンクはうまく動いてそうです。
showcaseはもうすでに動いていないので、リンクを削除してもいいような気がします。

@mehm8128
Copy link
Member Author

mehm8128 commented Jul 3, 2023

ogpIgnoreHostNamesのことかな
確かに消してよさそうなので、消しました

Copy link
Contributor

@nokhnaton nokhnaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なんか私が見るブランチ間違えてて変なこと言ってました。ごめんなさい。
ogpIgnoreHostNamesからshowcaseを削除するのは賛成なので、これでいいと思います

@mehm8128 mehm8128 merged commit 0a441f1 into master Jul 3, 2023
10 checks passed
@mehm8128 mehm8128 deleted the feat/replace_showcase_with_neoshowcase branch July 3, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants