画像モーダルの挙動の変更 #4071
Merged
画像モーダルの挙動の変更 #4071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
|
Preview
|
motoki317
reviewed
Sep 18, 2023
Comment on lines
291
to
294
| const afterScale = Math.max( | ||
| ZOOM_RATIO_MIN, | ||
| state.zoomRatio - e.deltaY * WHEEL_ZOOM_SCALE | ||
| ) |
There was a problem hiding this comment.
SPの方はいい感じになってたけど、PCでのctrl+マウスホイールでのズームインがすごく急になってる
前までは ZOOM_STEP ** zoomLevel でexpで(離散的に)計算してたけど、今ここがlinearになってるからかな
There was a problem hiding this comment.
とりあえず試しに指数関数の挙動に変えてみました
あとFirefoxなら一応e.deltaModeでトラックパッドの場合とマウスホイールの場合を見分けられそうなので係数を別で設定してみました
mehm8128
reviewed
Oct 8, 2023
zer0-star
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4063