Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

特定のバージョン以上のipadでもモーダルがクリックで閉じられるように #4117

Merged
merged 3 commits into from
Oct 27, 2023
Merged

特定のバージョン以上のipadでもモーダルがクリックで閉じられるように #4117

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7aec769
特定のバージョン以上のipadでもモーダルがクリックで閉じられるように
mehm8128 Oct 27, 2023
9e24122
macOSでisIOSがtrueにならないように
mehm8128 Oct 27, 2023
d65e3fd
コメントアウトで補足情報を追加
mehm8128 Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/lib/dom/browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,18 @@ export const isSafari = () => {
return ua.includes('safari') && !ua.includes('chrome') && !ua.includes('edge')
}

/** 特定の条件のiPadだとuaに'ipad'の文字列を含まない
* https://qiita.com/ShingoFukuyama/items/ef573a8e3e23ef12542e
* 'macinstosh'だとmacOSも含まれてしまうため、含まないように`'ontouchend' in document`の条件も追加
* https://jsnotice.com/posts/2019-09-08/index.html
*/
export const isIOS = () => {
return ua.includes('iphone') || ua.includes('ipod') || ua.includes('ipad')
return (
ua.includes('iphone') ||
ua.includes('ipod') ||
ua.includes('ipad') ||
(ua.includes('macintosh') && 'ontouchend' in document)
)
}

export const isFirefox = () => {
Expand Down