fix: manualChunksの指定が誤っていてビルド再現性がなかった #4150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview (prod) → https://4150-prod.traq-preview.trapti.tech/ |
sapphi-red
commented
Nov 15, 2023
| // hljsは適当に二つに分割する | ||
| const t = 'node_modules/highlight.js/lib/languages/' | ||
| const firstLetter = id.slice(id.indexOf(t) + t.length)[0] |
There was a problem hiding this comment.
tがidに含まれていないときid.indexOf(t)は-1なので、t.length - 1番目の文字を見ていた
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4150 +/- ##
=======================================
Coverage 86.35% 86.35%
=======================================
Files 66 66
Lines 4719 4719
Branches 564 564
=======================================
Hits 4075 4075
Misses 638 638
Partials 6 6 ☔ View full report in Codecov by Sentry. |
zer0-star
approved these changes
Nov 15, 2023
nokhnaton
deleted the
fix/non-reproducible-build-due-to-incorrect-manual-chunks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.