設定のブラウザタブのデザインの更新 #4222
Merged
設定のブラウザタブのデザインの更新 #4222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview (prod) → https://4222-prod.traq-preview.trapti.tech/ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4222 +/- ##
=======================================
Coverage 86.35% 86.35%
=======================================
Files 66 66
Lines 4719 4719
Branches 564 564
=======================================
Hits 4075 4075
Misses 638 638
Partials 6 6 ☔ View full report in Codecov by Sentry. |
mehm8128
reviewed
Jan 29, 2024
Comment on lines
+5
to
+12
| <p> | ||
| 特定のチャンネルを指定します。OFFの場合は最後に開いたチャンネルが設定されます。 | ||
| </p> | ||
| <form-selector | ||
| v-if="openMode === 'particular'" | ||
| v-model="openChannelNameValue" | ||
| :options="channelOptions" | ||
| /> |
Comment on lines
52
to
53
| if (openModeValue.value === 'lastOpen') openModeValue.value = 'particular' | ||
| else openModeValue.value = 'lastOpen' |
There was a problem hiding this comment.
ちょっと見づらいので囲ってほしいかもです
Suggested change
| if (openModeValue.value === 'lastOpen') openModeValue.value = 'particular' | |
| else openModeValue.value = 'lastOpen' | |
| if (openModeValue.value === 'lastOpen') { | |
| openModeValue.value = 'particular' | |
| } else { | |
| openModeValue.value = 'lastOpen' | |
| } |
mehm8128
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #2203
figma:
https://www.figma.com/file/6Wme6N24y3GN2jD0vqZWZr/traQ-S-UI?node-id=9779%3A22777&mode=dev
動作確認:
通知はブラウザの設定から変更可能。デフォルト(確認)、許可、拒否の3状態がある。