Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HorizontalPortrait: Unify algorithm job namespace & introduce template defaulting #69

Merged
merged 2 commits into from
Oct 18, 2023
Merged

HorizontalPortrait: Unify algorithm job namespace & introduce template defaulting #69

merged 2 commits into from
Oct 18, 2023

Conversation

zqzten
Copy link
Member

@zqzten zqzten commented Oct 18, 2023

What type of PR is this?

/kind feature
/kind algorithm

What this PR does / why we need it:

This PR does below two changes:

  1. Changes the namespace of algorithm job from HorizontalPortrait namespace to a unified namespace, which enables unified rbac management and volume sharing.
  2. Introduces defaulting for job image and metrics server and auto injection of HorizontalPortrait namespace name, which minimizes user configuration in IHPA.

@zqzten
hp: unify algorithm job namespace & introduce template defaulting
b4af67c 
Signed-off-by: Zach Zhu <zzqshu@126.com>
@zqzten
algo: adapt to new auto injected envs
9e56de7 
Signed-off-by: Zach Zhu <zzqshu@126.com>
@zqzten zqzten added kind/feature Categorizes issue or PR as related to a new feature or enhancements of an existing feature. kind/algorithm Categorizes issue or PR as related to algorithm. labels Oct 18, 2023
@zqzten zqzten added this to the v0.2 milestone Oct 18, 2023
@zqzten zqzten requested a review from dayko2019 October 18, 2023 12:14
dayko2019
dayko2019 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@dayko2019 dayko2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dayko2019 dayko2019 merged commit 4e6365b into traas-stack:main Oct 18, 2023
2 checks passed
@zqzten zqzten modified the milestones: v0.2, algorithm-v0.1 Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dayko2019 dayko2019 dayko2019 approved these changes

Assignees
No one assigned
Labels
kind/algorithm Categorizes issue or PR as related to algorithm. kind/feature Categorizes issue or PR as related to a new feature or enhancements of an existing feature.
Projects
None yet
Milestone
algorithm-v0.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zqzten @dayko2019