This repository has been archived by the owner on Mar 1, 2023. It is now read-only.
Fixes tiapp.xml to allow building for android right after running titanium-backbone new
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the parameter er (--puburl) to set the publisher url. Changes the way app id is generated to use the reverse domain + app name. Adds an app icon.png for android and iPhone.
trabianmatt
added a commit
that referenced
this pull request
May 29, 2012
Fixes tiapp.xml to allow building for android right after running `titanium-backbone new`
|
@svallory, Thanks for the pull request -- I particularly like the appicon. One thing I noticed while merging this is that I hadn't checked the KitchenSink against Titanium 2.0. I ended up needing to update a few sizes (setting ContentBlock height to Ti.UI.SIZE and table row heights to 44). Note that we haven't done anything with Android within this app yet. On the production app that we're extracting this from we had two separate packaging scripts. They both included a base set of functionality but one included iOS-specific code (especially styles) and the other included Android-specific code. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the parameter -u (--puburl) to set the publisher url. Changes the
way app id is generated to use the reverse domain + app name. Adds an
app icon.png for android and iPhone.
I really think we should have a shorter name :)