Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make trac-github a proper namespace package #132

Closed
wants to merge 3 commits into from
Closed

Make trac-github a proper namespace package #132

wants to merge 3 commits into from

Conversation

rjollos
Copy link
Member

@rjollos rjollos commented Apr 4, 2018

Refs #131.

@rjollos
Make this a proper namespace package
a7ef783
@rjollos
GitHubMixin doesn't need to inherit from Component
6f4f97d 
All of the classes utilizing the mixin inherit from
Component, and we don't need to support enabling/
disabling GitHubMixin.
@rjollos rjollos mentioned this pull request Apr 5, 2018
Closed
@rjollos
Fix test failure due to section already present
a30d756 
The section already present is due to an `Option`
defined on a class that doesn't inherit from Component:
https://trac.edgewall.org/ticket/12457
@rjollos rjollos self-assigned this Apr 8, 2018
@rjollos
Copy link
Member Author

rjollos commented Apr 8, 2018

Squashed and merged in deaec86.

@rjollos rjollos closed this Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neverpanic neverpanic neverpanic approved these changes

Assignees

@rjollos rjollos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rjollos @neverpanic