Fix mock migration #7
Conversation
|
regarding users creation, do they get email sent out? and what is their initial state? active? blocked? as if i created (disabled) users manually i encountered such issue: as if i'm importing i will have lots of dead users whose accounts need to be created and their accounts disabled. meaning also that the emails the users have are already invalid. |
| project = project_name.strip() | ||
| if not project: | ||
| raise ValueError('invalid project name: {!r}'.format(project_name)) | ||
| namespace, project = split_project_components(project) |
There was a problem hiding this comment.
gitlab 9 has nested groups support! this may break if enabled.
There was a problem hiding this comment.
Thanks, I was not aware of nested groups, I have to figure out how are they stored in the database schema, I'm going to try with GitLab 9.0.0...
|
About users creation, I still have to figure out how to handle it gracefully, but for an initial release I was thinking about creating accounts in 'active' state and sending out simple notification emails just to inform the user an account has been created, of course at the first login he must go through a password reset procedure since I don't want to send generated passwords around. |
|
i want users be created with state = blocked; type = external user. so perhaps make it configurable. altho i planned to create all missing users manually, until i saw you implemented user creation from the tool itself. and if using database direct mode, then likely the users will be created silently (no mails being sent out). i.e the gitlab bug i referred does not apply. |
Misc fixes to have mock migration working. Now users, namespace and project will be created if not already present in GitLab database.