Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[modern] websocket keeps connected after logout #896

Closed
mishika92 opened this issue Aug 26, 2021 · 1 comment
Closed

[modern] websocket keeps connected after logout #896

mishika92 opened this issue Aug 26, 2021 · 1 comment

Comments

@mishika92
Copy link

Describe the bug
When we press "Logout" we kill the session and go to the login screen, but the websocket connection stays alive.

To Reproduce
Steps to reproduce the behavior:

  1. login with an account A
  2. logout
  3. if you go to developer tools > network you will see the socket still open and receiving messages (if any)
  4. login with a different account B that doesn't have the devices from account A. If the devices from A are sending positions, you will see the devices from account A appearing in account B

Expected behavior
When modern app logs out it should kill the websocket.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows
  • Browser Chrome 92, Firefox 91

Smartphone (please complete the following information):

Additional context
The web app should close its websocket. But shouldn't the /api/socket endpoint in the server kill the corresponding connection after DELETE /api/session is called?
@tananaev
Copy link
Member

tananaev commented Sep 6, 2021

The issue is fixed.

mail2bishnoi pushed a commit to mail2bishnoi/traccar-web that referenced this issue Feb 15, 2022
@tananaev @mail2bishnoi
# This is a combination of 30 commits.
682bc9d 
# This is the 1st commit message:

Close socket on logout (fix traccar#896)

# This is the commit message traccar#2:

Fix lint

# This is the commit message traccar#3:

Add calendar menu

# This is the commit message traccar#4:

Add calendar file upload

# This is the commit message traccar#5:

Disable icon tinting in Firefox

# This is the commit message traccar#6:

Move ignition icon

# This is the commit message traccar#7:

Specify icon sizes

# This is the commit message traccar#8:

Fix lint issues

# This is the commit message traccar#9:

Add accuracy button

# This is the commit message traccar#10:

Merge shock and vibration alarms

# This is the commit message traccar#11:

Add events alarm column

# This is the commit message traccar#12:

Enable LocationIQ by default

# This is the commit message traccar#13:

Update LocationIQ keys

# This is the commit message traccar#14:

Fix selector style

# This is the commit message traccar#15:

Support server change

# This is the commit message traccar#16:

Update localization script

# This is the commit message traccar#17:

Update localization

# This is the commit message traccar#18:

Command to install dependency

# This is the commit message traccar#19:

Update JavaScript libraries

# This is the commit message traccar#20:

Fix modern app issues

# This is the commit message traccar#21:

Fix image URL

# This is the commit message traccar#22:

Fix user list (fix traccar#898)

# This is the commit message traccar#23:

Fix formatting issue

# This is the commit message traccar#24:

Add option to disable reports

# This is the commit message traccar#25:

Fix add button position

# This is the commit message traccar#26:

Select device based on uniqueId

# This is the commit message traccar#27:

Update devices list search

# This is the commit message traccar#28:

Fix lint problems

# This is the commit message traccar#29:

Changed devices list search

# This is the commit message traccar#30:

Changed device list search
mail2bishnoi added a commit to mail2bishnoi/traccar-web that referenced this issue Feb 15, 2022
@mail2bishnoi
Rebase replay_screen pr
cbbec6f 
Close socket on logout (fix traccar#896)

Fix lint

Add calendar menu

Add calendar file upload

Disable icon tinting in Firefox

Move ignition icon

Specify icon sizes

Fix lint issues

Add accuracy button

Merge shock and vibration alarms

Add events alarm column

Enable LocationIQ by default

Update LocationIQ keys

Fix selector style

Support server change

Update localization script

Update localization

Command to install dependency

Update JavaScript libraries

Fix modern app issues

Fix image URL

Fix user list (fix traccar#898)

Fix formatting issue

Add option to disable reports

Fix add button position

Select device based on uniqueId

Update devices list search

Fix lint problems

Changed devices list search

Changed device list search

Update translation for Search Devices

Changed translation for Update Devices

Changed translation for Update Devices

Fix MainToolbar settings icon

Resolves traccar#892

Fix multiple events issue

Changed notification approach

Changed notification approach

Changed notification approach
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tananaev @mishika92