-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StatusCard on mobile screens hides the device on the map #1155
Conversation
@@ -57,6 +57,8 @@ const useStyles = makeStyles((theme) => ({ | |||
content: { | |||
paddingTop: theme.spacing(1), | |||
paddingBottom: theme.spacing(1), | |||
'max-height': '40vh', | |||
overflow: 'hidden', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we hiding overflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because it overlaps with the actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Screenshot please. And also wouldn't it mean that it's not the content is not accessible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the overflow content won't be accesible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not an acceptable solution then. It should become scrollable if you want to limit the height.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -57,6 +57,8 @@ const useStyles = makeStyles((theme) => ({ | |||
content: { | |||
paddingTop: theme.spacing(1), | |||
paddingBottom: theme.spacing(1), | |||
'max-height': '40vh', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to use camelcase name here. And also the constant should be in the same place where we put other similar constants. It's part of the theme.
please check |
Merged, thanks. |
@jcardus is looks like the card is broken by this change. Tested on Chrome on Mac. Can you please fix. ![]() |
Sorry @tananaev, I just saw this now. Is this still an issue? |
I forgot. Maybe I already fixed it? |
I can't reproduce it. |
before:
![traccar fleetmap io_(iPhone SE) (1)](https://private-user-images.githubusercontent.com/31902485/256999820-84e4b17f-88cb-4132-9df4-c2fcfc54168e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA2MjQ5NDksIm5iZiI6MTcyMDYyNDY0OSwicGF0aCI6Ii8zMTkwMjQ4NS8yNTY5OTk4MjAtODRlNGIxN2YtODhjYi00MTMyLTlkZjQtYzJmY2ZjNTQxNjhlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEwVDE1MTcyOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI0NGMwMDE1ZGFkNWIzNmJiMThkNjE2MzFjMjVmMWY3ZWQ3ZmExMTMzNTY1YzViYzZhZDZlOTRjZDVmMzRkMGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.8puUvEbMHt_wUlVwaacx7chLAB-tIIGJNDi_EQT0ux0)
after:
![localhost_3000_(iPhone SE)](https://private-user-images.githubusercontent.com/31902485/256999877-ff4c7ab7-a4ab-4373-ba4b-d2274c0535c0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA2MjQ5NDksIm5iZiI6MTcyMDYyNDY0OSwicGF0aCI6Ii8zMTkwMjQ4NS8yNTY5OTk4NzctZmY0YzdhYjctYTRhYi00MzczLWJhNGItZDIyNzRjMDUzNWMwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEwVDE1MTcyOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZjN2JiZjg1NzQzN2I1M2I2ZDc5NWExZTdkY2FhMTNiNTQ2ZmJhOTcwMTZkMzc0YmI1YWY5YWY5OWYwNzY0OWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.XaaKX8VfEgkV4wXNzdpc-Kjzu_6VuHJ3tpLVZTlLTNc)