here geocoder url config parameter #4472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
checkStyle failing... |
|
What's the new URL? I think we should set at least to be a default. |
|
https://reverse.geocoder.api.here.com/6.2/reversegeocode.json I put it on the unit test. My api_key doesn't work with the old url. By the way I'm having problems trying to fix the unit tests, It has to be run with the Conext initialized because of the "concrete map type error". But we need a settings file for that and I think it's too much for such a small test. Any idea on this? |
|
sorry, https://reverse.geocoder.ls.hereapi.com/6.2/reversegeocode.json |
added default url for here
tananaev
reviewed
Jan 21, 2020
| return url; | ||
| private static String formatUrl(String url, String id, String key, String language) { | ||
| if (url == null) { | ||
| url = "https://reverse.geocoder.ls.hereapi.com/6.2/reversegeocode.json"; |
| @@ -73,7 +73,7 @@ public void testBan() { | |||
| @Ignore | |||
| @Test | |||
| public void testHere() { | |||
| Geocoder geocoder = new HereGeocoder("", "", null, 0, new AddressFormat()); | |||
| Geocoder geocoder = new HereGeocoder("https://reverse.geocoder.ls.hereapi.com/6.2/reversegeocode.json", "", "", null, 0, new AddressFormat()); | |||
added 3 commits
January 21, 2020 17:59
removed url from here geocode test
intellij uses 2 spaces, this project uses 4.
intellij uses 2 spaces, this project uses 4.
tananaev
reviewed
Jan 21, 2020
| @@ -73,7 +73,7 @@ public void testBan() { | |||
| @Ignore | |||
| @Test | |||
| public void testHere() { | |||
| Geocoder geocoder = new HereGeocoder("", "", null, 0, new AddressFormat()); | |||
| Geocoder geocoder = new HereGeocoder("", "", "", null, 0, new AddressFormat()); | |||
There was a problem hiding this comment.
This doesn't look right. Shouldn't the URL be null?
added 2 commits
January 21, 2020 18:14
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like it was hardcoded.
The here url has changed.