request pagination #5207
Closed
request pagination #5207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tananaev
reviewed
Nov 9, 2023
Comment on lines
319
to
331
| if(pagination.getSkip() > 0) { | ||
| result.append(" OFFSET "); | ||
| result.append(pagination.getSkip()); | ||
| } | ||
| if (pagination.getLimit() > 0) { | ||
| if (databaseType.equals("Microsoft SQL Server")) { | ||
| result.append(" OFFSET 0 ROWS FETCH FIRST "); | ||
| result.append(order.getLimit()); | ||
| result.append(pagination.getLimit()); | ||
| result.append(" ROWS ONLY"); | ||
| } else { | ||
| result.append(" LIMIT "); | ||
| result.append(order.getLimit()); | ||
| result.append(pagination.getLimit()); | ||
| } |
There was a problem hiding this comment.
Which databases have you tested?
There was a problem hiding this comment.
We need to test at least H2, MySQL, Postgres and MS SQL. Is there an SQL standard for it?
There was a problem hiding this comment.
code wise, the path is correct?
There was a problem hiding this comment.
I only did a brief look, but I think it makes sense. I would separate database changes and report changes though.
|
@tananaev regarding docs: is it automatically updated or should I do some manual work here? If so, can you point me where should I pay attention and update? ty |
|
What docs do you need to update? |
|
the api ones to include the new |
|
Well, we need to split the PR first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
Core
Implementation
Databases Tested
@tananaev