Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Span completer never shuts down #832

Open
soujiro32167 opened this issue Jan 2, 2023 · 2 comments
Open

Span completer never shuts down #832

soujiro32167 opened this issue Jan 2, 2023 · 2 comments

Comments

@soujiro32167
Copy link
Contributor

soujiro32167 commented Jan 2, 2023

I've got an integration test that runs a web app with NewrelicSpanCompleter.

It never shuts down after upgrading to v0.14.1:

Scala 2.13.10
JDK 17

import cats.effect.{ExitCode, IO, IOApp, Resource}
import org.http4s.jdkhttpclient.JdkHttpClient
import trace4cats.model.TraceProcess
import trace4cats.newrelic.{Endpoint, NewRelicSpanCompleter}
import trace4cats.{EntryPoint, SpanSampler}

object catstracing extends IOApp {
    val app = for {
      client <- Resource.eval(JdkHttpClient.simple[IO])
      completer <- NewRelicSpanCompleter[IO](client, TraceProcess("foo"), "???", Endpoint.US)
      ep = EntryPoint[IO](SpanSampler.always[IO], completer)
      root <- ep.root("root span")
    } yield root

    override def run(args: List[String]): IO[ExitCode] =
      app.use(root => IO.println(root.context)).as(ExitCode.Success)
}
@soujiro32167
Copy link
Contributor Author

If I run it as a fiber, its impossible to interrupt either...

@ybasket
Copy link
Contributor

ybasket commented Feb 13, 2024

@soujiro32167 could you retest with the 0.14.7 version? There were some fixes to the span completer internals that could have resolved this since you opened this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants