-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
virustotal3.enterprise.file_feed()
broken
#4
Comments
Looks like there was a change in the API on VirusTotal's side. I'll look into it and make the necessary changes next week probably. Thanks for reporting.
Sent from ProtonMail mobile
…-------- Original Message --------
On Mar. 18, 2020, 4:47 p.m., Evan wrote:
I don't know if this worked at one point and the API changed or what but it redirects to a bz2 file now and requests seems to handle it transparently. Returning .json() causes and exception because the bz2 file can't be parsed as json.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, [view it on GitHub](#4), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AJL3MOCJLJLOO44UMXOZYKLRIEXOBANCNFSM4LO2HTJQ).
|
You might update the docs while you're there as well. Looks like packages must be an hour old before they are downloadable instead of 5 minutes. Thanks for being so responsive. If you know how you want it to work already I'm pretty open to submitting a PR. |
ohh, also, it looks like a 404 shouldn't be treated as an exception every time now. |
Sure, pull requests are more than welcome as I'm short on time these days to work on this, especially with the current pandemic.
Thanks for the help!
Sent from ProtonMail mobile
…-------- Original Message --------
On Mar. 18, 2020, 6:21 p.m., Evan wrote:
You might update the docs while you're there as well. Looks like packages must be an hour old before they are downloadable instead of 5 minutes. Thanks for being so responsive. If you know how you want it to work already I'm pretty open to submitting a PR.
—
You are receiving this because you commented.
Reply to this email directly, [view it on GitHub](#4 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AJL3MOBWS2CJPPPACBZQWI3RIFCNJANCNFSM4LO2HTJQ).
|
Hey, unfortunately I no longer have access to file feed. It's a separate feature from the standard Enterprise subscription. If you or someone else could fix it, it'd be appreciated, otherwise I might remove it to avoid further issues to be opened. I must have misread the documentation on this one, I just had a look. You're right that it should return a bzip2. Thanks |
I can put in an MR if you want. If you know that you want it to work a certain way already then let me know. Otherwise I'll just do what seems to make the most sense to me. |
I don't know if this worked at one point and the API changed or what but it redirects to a bz2 file now and requests seems to handle it transparently. Returning
.json()
causes and exception because the bz2 file can't be parsed as json.The text was updated successfully, but these errors were encountered: