Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virustotal3.enterprise.file_feed() broken #4

Closed
xaocon opened this issue Mar 18, 2020 · 6 comments · Fixed by #5
Closed

virustotal3.enterprise.file_feed() broken #4

xaocon opened this issue Mar 18, 2020 · 6 comments · Fixed by #5

Comments

@xaocon
Copy link

xaocon commented Mar 18, 2020

I don't know if this worked at one point and the API changed or what but it redirects to a bz2 file now and requests seems to handle it transparently. Returning .json() causes and exception because the bz2 file can't be parsed as json.

@traceflow
Copy link
Owner

traceflow commented Mar 18, 2020 via email

@xaocon
Copy link
Author

xaocon commented Mar 18, 2020

You might update the docs while you're there as well. Looks like packages must be an hour old before they are downloadable instead of 5 minutes. Thanks for being so responsive. If you know how you want it to work already I'm pretty open to submitting a PR.

@xaocon
Copy link
Author

xaocon commented Mar 18, 2020

ohh, also, it looks like a 404 shouldn't be treated as an exception every time now.

@traceflow
Copy link
Owner

traceflow commented Mar 18, 2020 via email

@traceflow
Copy link
Owner

traceflow commented Apr 14, 2020

Hey, unfortunately I no longer have access to file feed. It's a separate feature from the standard Enterprise subscription. If you or someone else could fix it, it'd be appreciated, otherwise I might remove it to avoid further issues to be opened. I must have misread the documentation on this one, I just had a look. You're right that it should return a bzip2. Thanks

@xaocon
Copy link
Author

xaocon commented Apr 15, 2020

I can put in an MR if you want. If you know that you want it to work a certain way already then let me know. Otherwise I'll just do what seems to make the most sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants