Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tanh_should_not_have_numerical_bugs_on_macos is failing on MacOS #1086

Closed
antimora opened this issue Dec 19, 2023 · 2 comments · Fixed by #1090
Closed

tanh_should_not_have_numerical_bugs_on_macos is failing on MacOS #1086

antimora opened this issue Dec 19, 2023 · 2 comments · Fixed by #1090
Assignees
Labels
bug Something isn't working

Comments

@antimora
Copy link
Collaborator

Describe the bug

failures:

---- kernel::unary::tests::tanh_should_not_have_numerical_bugs_on_macos stdout ----
thread 'kernel::unary::tests::tanh_should_not_have_numerical_bugs_on_macos' panicked at burn-wgpu/src/kernel/unary.rs:260:9:
assertion failed: !zero.is_nan() && zero == 1.0


failures:
    kernel::unary::tests::tanh_should_not_have_numerical_bugs_on_macos

test result: FAILED. 1238 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 14.63s

error: test failed, to rerun pass `-p burn-wgpu --lib`

To Reproduce
./run-checks all

Desktop (please complete the following information):

[burn]$ uname -a
Darwin MacBook-Pro-Max.attlocal.net 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:33:00 PDT 2023; root:xnu-10002.41.9~7/RELEASE_ARM64_T6031 arm64
[burn]$ 
@antimora antimora added the bug Something isn't working label Dec 19, 2023
@louisfd
Copy link
Member

louisfd commented Dec 20, 2023

Fails for me too. It's due to @nathanielsimard 's refactoring (#1069) in which the "safe_tanh" alternative was removed

@nathanielsimard
Copy link
Member

@louisfd We can reintroduce the "hack," but with the new codegen in place. I would have thought that the new Mac CI would have encountered the same error, but I suppose it might be specific to newer Macs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants