Fix/wgpu/tanh #1090
Merged
Fix/wgpu/tanh #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielsimard
requested changes
Dec 21, 2023
| @@ -6,13 +6,15 @@ use std::fmt::Display; | |||
| pub enum Function { | |||
| Powf(Elem), | |||
| Erf(Elem), | |||
| SafeTanh(Elem), | |||
There was a problem hiding this comment.
Add a feature flag for macos
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1090 +/- ##
==========================================
- Coverage 85.41% 85.41% -0.01%
==========================================
Files 511 511
Lines 54670 54675 +5
==========================================
Hits 46699 46699
- Misses 7971 7976 +5 ☔ View full report in Codecov by Sentry. |
nathanielsimard
approved these changes
Dec 21, 2023
syl20bnr
added a commit
to syl20bnr/burn
that referenced
this pull request
Jan 4, 2024
This reverts commit b070706.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1086