Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

burn-tch does not run/build with mac m1/m2 and linux aarch64 #180

Closed
antimora opened this issue Feb 26, 2023 · 5 comments
Closed

burn-tch does not run/build with mac m1/m2 and linux aarch64 #180

antimora opened this issue Feb 26, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@antimora
Copy link
Collaborator

antimora commented Feb 26, 2023 •
edited

Describe the bug
Build/test fails on burn-tch: cargo test on Mac M1/M2 and aarch64 linux.

To Reproduce
on Mac M1/M2 or aarch64 linux run cargo test on burn-tch

OS Information

bash: uname -a
Darwin MacBook-Pro.local 22.3.0 Darwin Kernel Version 22.3.0: 
Mon Jan 30 20:38:37 PST 2023; root:xnu-8792.81.3~2/RELEASE_ARM64_T6000 arm64


[burn]$ uname -a
Linux e80e5571e6de 5.15.49-linuxkit #1 SMP PREEMPT Tue Sep 13 07:51:32 UTC 2022
 aarch64 aarch64 aarch64 GNU/Linux
@antimora
Copy link
Collaborator Author

This could be related to: LaurentMazare/tch-rs#542

@antimora
Copy link
Collaborator Author

antimora commented Feb 27, 2023 •
edited

I filled a ticket with tch-rs team: LaurentMazare/tch-rs#629

I found a solution for Mac that works for me. I'll codify my solution and check in.

antimora added a commit to antimora/burn that referenced this issue Feb 28, 2023
@antimora
Add a workaround script for arm64 tch-rs build issue (tracel-ai#180)
3c804a1
antimora added a commit to antimora/burn that referenced this issue Feb 28, 2023
@antimora
Add a workaround script for arm64 tch-rs build issue (tracel-ai#180)
644683a
antimora added a commit to antimora/burn that referenced this issue Feb 28, 2023
@antimora
Fix the issues identified during PR review (tracel-ai#180)
236bf48
nathanielsimard pushed a commit that referenced this issue Mar 1, 2023
@antimora
Add a workaround script for arm64 tch-rs build issue (#180) (#182)
a62738b 
* Add a workaround script for arm64 tch-rs build issue (#180)
antimora added a commit to antimora/burn that referenced this issue Mar 1, 2023
@antimora
Fix tch build issue from the root (tracel-ai#180)
feb9810 
Moved .cargo/config.toml to the root so that the project can be built from the root and burn-tch as well.
nathanielsimard pushed a commit that referenced this issue Mar 1, 2023
@antimora
Fix tch build issue from the root (#180) (#189)
30f6a30 
Moved .cargo/config.toml to the root so that the project can be built from the root and burn-tch as well.
@antimora
Copy link
Collaborator Author

antimora commented Mar 5, 2023

Here is a temporary workaround script (now as part of burn): https://github.com/burn-rs/burn/blob/main/scripts/fix-tch-build-arm64.py . This ticket will remain open till the problem is fixed in upstream libs: tch-rs and torch.

@antimora antimora mentioned this issue Mar 11, 2023
Closed
@antimora
Copy link
Collaborator Author

antimora commented Apr 2, 2023

The upstream has a fix for this but it's not released yet: LaurentMazare/tch-rs#661

@antimora antimora added the bug Something isn't working label Apr 2, 2023
@antimora
Copy link
Collaborator Author

These two PRs #347 and #345 close this ticket. We will have to remove the script once the release is made. We still can keep it because not all will upgrade at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@antimora