Fix/wgpu/fusion #1093
Merged
Fix/wgpu/fusion #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louisfd
approved these changes
Dec 22, 2023
burn-fusion/src/handle.rs
Outdated
| /// | ||
| /// # Warnings | ||
| /// | ||
| /// Make sure the status correspond to the operation you want ot execute the handles one, |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1093 +/- ##
==========================================
+ Coverage 85.41% 85.47% +0.05%
==========================================
Files 511 511
Lines 54675 54759 +84
==========================================
+ Hits 46700 46804 +104
+ Misses 7975 7955 -20 ☔ View full report in Codecov by Sentry. |
syl20bnr
added a commit
to syl20bnr/burn
that referenced
this pull request
Jan 4, 2024
This reverts commit b0a2b30.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for fused element-wise integer operations.
But most importantly, actually enable fusion without the need for sync. That's right, we didn't have fused operations in real settings, and there was a bug when fusion was triggered by an operation instead of a sync, and this PR fixes this.